Skip to content

expose hidden BLTOUCH setting changes#22069

Merged
shitcreek merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
ellensp:bltouch
Jun 7, 2021
Merged

expose hidden BLTOUCH setting changes#22069
shitcreek merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
ellensp:bltouch

Conversation

@ellensp
Copy link
Copy Markdown
Contributor

@ellensp ellensp commented Jun 7, 2021 •
edited
Loading

Description

When you enable BLTOUCH, Marlin quietly resets DEACTIVATE_SERVOS_AFTER_MOVE, Z_MIN_PROBE_ENDSTOP_INVERTING and Z_MIN_ENDSTOP_INVERTING to what is needed by the BLTOUCH.

This leads to many user arguments along the lines of "I have Z_MIN_ENDSTOP_INVERTING set true, and BLTOUCH works for me" Immediately followed by a second user says the opposite "I have Z_MIN_ENDSTOP_INVERTING set false, and BLTOUCH works for me" and on and on...

This exposes that Marlin is resetting these defines to what is actually needed by BLTOUCH

Requirements

BLTOUCH and various combinations of DEACTIVATE_SERVOS_AFTER_MOVE, Z_MIN_ENDSTOP_INVERTING and Z_MIN_PROBE_ENDSTOP_INVERTING

Benefits

Less confused users, cleaner Config files that have correct settings.

@shitcreek shitcreek merged commit 588a74f into MarlinFirmware:bugfix-2.0.x Jun 7, 2021
@ellensp ellensp deleted the bltouch branch June 8, 2021 00:56
@thinkyhead
Copy link
Copy Markdown
Member

thinkyhead commented Jun 8, 2021 •
edited
Loading

Sorry this was merged before I had a chance to review it. I will make sure all admins are brought up to date on the no-merge policy ASAP.

If a setting is very important then use #error and not #warning to force the user to change it. Or, if a setting is meaningless for BLTOUCH then maybe wrap it in #if DISABLED(BLTOUCH) … #endif. The problem with a #warning is that it scrolls by, the build succeeds, and users never see the warning.

@DrumClock
Copy link
Copy Markdown

DrumClock commented Jun 8, 2021 •
edited
Loading

Ahoj, využívám funkci SWITCHING_EXTRUDER_SERVO_NR 1 a SWITCHING_EXTRUDER_E23_SERVO_NR 2 kde jsem měl povolenou funkci DEACTIVATE_SERVOS_AFTER_MOVE aby serva nebyla zbytečně pod napětím a "nevrčela".

Teď mi to při kompilaci hlásí:
#warning "BLTOUCH requires DEACTIVATE_SERVOS_AFTER_MOVE to be to disabled. Undefining DEACTIVATE_SERVOS_AFTER_MOVE. Please update your Configuration.h file."

Ale jde to zkompilovat, tak nevím jestli je to v pořádku, mě BLTOUCH fungoval bez problémů.....
A nevím jestli s tím nesouvisí tato chyba: #22043

@thinkyhead
Copy link
Copy Markdown
Member

thinkyhead commented Jun 9, 2021

@DrumClock — Please stop cross-posting on other issues! It is obnoxious!

@MarlinFirmware MarlinFirmware locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

C: Configuration F: BLTouch PR: Improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ellensp @thinkyhead @DrumClock @shitcreek